Function not Functional

[Sabri CHARCHOUF]

I create the below function in order to connect to vCenter, unfortunately when I run it nothing happen

[CmdletBinding()]

    param (

    [Parameter(Mandatory = $true)]

    [ValidateNotNullOrEmpty()]

    [string]$Server,

   

    [Parameter(Mandatory = $true)]

    [ValidateNotNullOrEmpty()]

    [string]$Username,

   

    [Parameter(Mandatory = $true)]

    [ValidateNotNullOrEmpty()]

    [SecureString]$Password

    )

    try {

        # Import the VMware PowerCLI module

        Import-Module -Name VMware.PowerCLI -ErrorAction Stop

        # Connect to vCenter

        Connect-VIServer -Server $Server -User $Username -Password $Password

        # Output success message

        Write-Output "Connected to vCenter successfully"

    }

    catch {

        # Log the error

        Write-Error "Failed to connect to vCenter: $_"

    }

}

[LucD]

How do you call that function?
I assume you did include a function line at the start?

[Sabri CHARCHOUF]

No, I didn't include that at the start

[LucD]

You have to give some more details.
Did you store that code in a separate .ps1 file?
Did you dot-source that .ps1 file to make the function "known" to the PS engine?
Or is everything stored in a single .ps1 file?

[Sabri CHARCHOUF]

All things are stored on a single file.

The idea is that I would like to have a function, that give as the way to entrer vCenter detail then user name and login

The same function should check the required modules

[LucD]

If it is all in the same .ps1 file, you should have a function statement.
And then call that function

Something like this

function Get-WhatEver {

# function statements

}

# call the function
Get-WhatEver

[Sabri CHARCHOUF]

Thanks got it  

Just a question why I get the below message when I run the script? is there a way to hide it?

cmdlet Connect-VCenter at command pipeline position 1
Supply values for the following parameters:

[LucD]

You made all the parameters Mandatory, so you should provide these mandatory parameter when you call the function

[Sabri CHARCHOUF]

function Connect-VCenter {
    [CmdletBinding()]
    param (
    [Parameter(Mandatory = $true)]
    [ValidateNotNullOrEmpty()]
    [string]$Server,
    
    [Parameter(Mandatory = $true)]
    [ValidateNotNullOrEmpty()]
    [string]$Username,
    
    [Parameter(Mandatory = $true)]
    [ValidateNotNullOrEmpty()]
    [SecureString]$Password

    )
    try {
        # Import the VMware PowerCLI module
        Import-Module -Name VMware.PowerCLI -ErrorAction Stop

        # Connect to vCenter
        Connect-VIServer -Server $Server -User $Username -Password $Password

        # Output success message
        Write-Output "Connected to vCenter successfully"
    }
    catch {
        # Log the error
        Write-Error "Failed to connect to vCenter: $_"
    }
}
Connect-VCenter

I got the below error message

Failed to connect to vCenter: Method 'ConnectProcessRecordInternal' in type 'VMware.Sdk.Nsx.Policy.ConnectNsxServer' from assembly 'VMware.Sdk.Nsx.Policy.Cmdlets, Version=0.0.0.0, Culture=neutral,
| PublicKeyToken=null' does not have an implementation.

 

 

[LucD]

It is hard to believe you got that far since you provided no parameters on your call to Connect-VCenter, and all the parameters are mandatory.

[Sabri CHARCHOUF]

I manually typed in the entries in the console.
I provided the IP address of the vcenter, followed by the username and password.

[LucD]

Did you dot-source the .ps1 file before?
I'm not sure what exactly you are doing, but you should run the .ps1 file, not call the function from the prompt (unless you dot-sourced it before).

[Sabri CHARCHOUF]

Did you dot-source the .ps1 file before? No

My idea is that when I run the script I should enter Ip or vCenter FQDN followed by the login and user.

So when I run the script without calling the function nothing happen, when I add the call function it gaves me the possibility to enter detail bu failed with error message.

[LucD]

Try leaving out the ErrorAction on the Import-Module.

Import-Module -Name VMware.PowerCLI