Is New-VIProperty persistent between powershell sessions? Does it update the VCenter Server database permantently?
No, these definitions are not persistent, they live inside the PowerCLI session.
A solution is to place them in one of your PowerShell profiles, that way they will always be present in your sessions.